fix pydantic v2 wrap validators and silence deprecation warning#9
Merged
Centurix merged 2 commits intoMay 9, 2026
Merged
Conversation
Return validated instances from DANJAResource/DANJAResourceList wrap validators to comply with Pydantic v2 expectations and avoid the "return self" warning. Add regression tests for single/list resources with included payloads, and update resource id resolution to access model_fields from the model class to remove v2.11 deprecation warnings.
Owner
|
Thanks, that's a good solution and the regression works like a charm. Nice one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return validated instances from DANJAResource/DANJAResourceList wrap validators to comply with Pydantic v2 expectations and avoid the "return self" warning.
Add regression tests for single/list resources with included payloads, and update resource id resolution to access model_fields from the model class to remove v2.11 deprecation warnings.
Fixes This currently open issue